Merged
Conversation
…anagement options
…ling and error management
…ndling and user role validation
… input validation
…ation and error handling
yasserahmed10
added
enhancement
Test Results502 tests +125 479 ✅ +131 17s ⏱️ +7s For more details on these failures, see this check. Results for commit b40ebb8. ± Comparison against base commit f63df46. This pull request removes 20 and adds 144 tests. Note that renamed tests count towards both. |
|
❌ Test or Coverage checks failed! Please check the workflow run for details. |
aabukmail
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements to the test coverage of the UI components for authentication and project management. It replaces mocked annotations with
mockkobjects, adds new test cases for various scenarios, and ensures better handling of user roles and session states.Authentication Test Enhancements:
LoginUserUITest: Added new test cases to validate successful login, retry logic after failure, and handling of multiple login failures before success. These tests ensure robust behavior for different login scenarios.RegisterAdminUITest: Refactored to usemockkforConsoleIO, added detailed test cases for successful registration, retry logic after failure, and handling multiple registration failures. Enhanced password validation and error handling.Project Management Test Enhancements:
CreateProjectUITest: ReplacedMockKAnnotationswithmockkobjects, added test cases for admin and non-admin users, error handling during project creation, and state addition flow. Improved session management handling viaSessionManager.GetAllProjectsUITest: Added session-based role handling to differentiate behavior for admin and non-admin users. Introduced test cases to verify project display logic and improved mock setup for project data. [1] [2]These changes enhance the reliability and maintainability of the test suite by ensuring comprehensive coverage of edge cases and user role-specific behaviors.